Fix memleak with gst_static_pad_template_get().

Original commit message from CVS:
* ext/cairo/gsttextoverlay.c: (gst_text_overlay_init):
* ext/dv/gstdvdemux.c: (gst_dvdemux_init), (gst_dvdemux_add_pads):
* ext/gdk_pixbuf/gstgdkpixbuf.c: (gst_gdk_pixbuf_init):
* ext/jpeg/gstjpegdec.c: (gst_jpeg_dec_init),
(gst_jpeg_dec_setcaps):
* ext/jpeg/gstjpegenc.c: (gst_jpegenc_init):
* ext/jpeg/gstsmokedec.c: (gst_smokedec_init):
* ext/jpeg/gstsmokeenc.c: (gst_smokeenc_init):
* ext/libmng/gstmngdec.c: (gst_mngdec_init),
(gst_mngdec_src_getcaps):
* ext/libpng/gstpngdec.c: (gst_pngdec_init),
(gst_pngdec_caps_create_and_set):
* ext/libpng/gstpngenc.c: (gst_pngenc_init):
* ext/mikmod/gstmikmod.c: (gst_mikmod_init):
* ext/speex/gstspeexdec.c: (gst_speex_dec_init):
* gst/alpha/gstalpha.c: (gst_alpha_init):
* gst/auparse/gstauparse.c: (gst_au_parse_init):
* gst/avi/gstavidemux.c: (gst_avi_demux_init),
(gst_avi_demux_handle_src_event), (gst_avi_demux_parse_stream):
* gst/cutter/gstcutter.c: (gst_cutter_init):
* gst/debug/efence.c: (gst_efence_init), (gst_efence_getrange),
(gst_efence_checkgetrange):
* gst/debug/negotiation.c: (gst_negotiation_init):
* gst/flx/gstflxdec.c: (gst_flxdec_init):
* gst/goom/gstgoom.c: (gst_goom_init):
* gst/rtp/gstasteriskh263.c: (gst_asteriskh263_init):
* gst/rtp/gstrtpL16depay.c: (gst_rtp_L16depay_init):
* gst/rtp/gstrtpL16pay.c: (gst_rtpL16pay_init):
* gst/rtp/gstrtpamrdepay.c: (gst_rtp_amr_depay_init):
* gst/rtp/gstrtpdepay.c: (gst_rtp_depay_init):
* gst/rtp/gstrtpmpadepay.c: (gst_rtp_mpa_depay_init):
* gst/rtsp/gstrtpdec.c: (gst_rtpdec_init):
* gst/smpte/gstsmpte.c: (gst_smpte_init):
* gst/wavparse/gstwavparse.c: (gst_wavparse_init),
(gst_wavparse_create_sourcepad):
Fix memleak with gst_static_pad_template_get().
This uses gst_pad_new_from_static_template() instead.
Fixes #333512

2 files changed, 6 insertions, 12 deletions

diff --git a/gst/debug/efence.c b/gst/debug/efence.c
index 078a0e32..90932598 100644
--- a/gst/debug/efence.c
+++ b/gst/debug/efence.c
@@ -180,10 +180,8 @@ gst_efence_class_init (GstEFenceClass * klass)
 static void
 gst_efence_init (GstEFence * filter)
 {
-  GstPadTemplate *tmpl;
-
-  tmpl = gst_static_pad_template_get (&gst_efence_sink_factory);
-  filter->sinkpad = gst_pad_new_from_template (tmpl, "sink");
+  filter->sinkpad =
+      gst_pad_new_from_static_template (&gst_efence_sink_factory, "sink");
   gst_pad_set_getcaps_function (filter->sinkpad,
       GST_DEBUG_FUNCPTR (gst_pad_proxy_getcaps));
   gst_pad_set_setcaps_function (filter->sinkpad,
@@ -193,10 +191,9 @@ gst_efence_init (GstEFence * filter)
   gst_pad_set_bufferalloc_function (filter->sinkpad,
       GST_DEBUG_FUNCPTR (gst_efence_buffer_alloc));
   gst_element_add_pad (GST_ELEMENT (filter), filter->sinkpad);
-  gst_object_unref (tmpl);
 
-  tmpl = gst_static_pad_template_get (&gst_efence_src_factory);
-  filter->srcpad = gst_pad_new_from_template (tmpl, "src");
+  filter->srcpad =
+      gst_pad_new_from_static_template (&gst_efence_src_factory, "src");
   gst_pad_set_getcaps_function (filter->srcpad,
       GST_DEBUG_FUNCPTR (gst_pad_proxy_getcaps));
   gst_pad_set_setcaps_function (filter->srcpad,
@@ -209,7 +206,6 @@ gst_efence_init (GstEFence * filter)
       GST_DEBUG_FUNCPTR (gst_efence_activate_src_pull));
 
   gst_element_add_pad (GST_ELEMENT (filter), filter->srcpad);
-  gst_object_unref (tmpl);
 
   filter->fence_top = TRUE;
 }
diff --git a/gst/debug/negotiation.c b/gst/debug/negotiation.c
index da8a3033..c3f2314d 100644
--- a/gst/debug/negotiation.c
+++ b/gst/debug/negotiation.c
@@ -179,13 +179,11 @@ static void
 gst_negotiation_init (GstNegotiation * filter)
 {
   filter->sinkpad =
-      gst_pad_new_from_template (gst_static_pad_template_get
-      (&gst_negotiation_sink_factory), "sink");
+      gst_pad_new_from_static_template (&gst_negotiation_sink_factory, "sink");
   gst_pad_set_getcaps_function (filter->sinkpad, gst_negotiation_getcaps);
   gst_pad_set_link_function (filter->sinkpad, gst_negotiation_pad_link);
   filter->srcpad =
-      gst_pad_new_from_template (gst_static_pad_template_get
-      (&gst_negotiation_src_factory), "src");
+      gst_pad_new_from_static_template (&gst_negotiation_src_factory, "src");
   gst_pad_set_getcaps_function (filter->srcpad, gst_negotiation_getcaps);
   gst_pad_set_link_function (filter->srcpad, gst_negotiation_pad_link);