diff options
| author | Tim-Philipp Müller <tim.muller@collabora.co.uk> | 2009-08-02 11:44:03 +0100 |
|---|---|---|
| committer | Tim-Philipp Müller <tim.muller@collabora.co.uk> | 2009-08-02 11:50:43 +0100 |
| commit | 6c323f5b0d8a82aa88c10f62cd8a2b824a08db69 (patch) | |
| tree | 91dff8abe4cbc9fd077285a5472d8d70e377d3d7 /gst/udp | |
| parent | a3c393248a69a2ec7dd8ce168ef2f07cb93bac1b (diff) | |
multiudpsink: don't do things with side-effects inside g_return_val_if_fail()
Someone might compile this code with -DG_DISABLE_ASSERT some day.
Diffstat (limited to 'gst/udp')
| -rw-r--r-- | gst/udp/gstmultiudpsink.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/gst/udp/gstmultiudpsink.c b/gst/udp/gstmultiudpsink.c index 68eea75c..a6afc9ae 100644 --- a/gst/udp/gstmultiudpsink.c +++ b/gst/udp/gstmultiudpsink.c @@ -117,7 +117,7 @@ static void gst_multiudpsink_finalize (GObject * object); static GstFlowReturn gst_multiudpsink_render (GstBaseSink * sink, GstBuffer * buffer); -#ifndef G_OS_WIN32 /*sendmsg() is not available on Windows*/ +#ifndef G_OS_WIN32 /* sendmsg() is not available on Windows */ static GstFlowReturn gst_multiudpsink_render_list (GstBaseSink * bsink, GstBufferList * list); #endif @@ -451,8 +451,9 @@ gst_multiudpsink_render_list (GstBaseSink * bsink, GstBufferList * list) sink = GST_MULTIUDPSINK (bsink); g_return_val_if_fail (list != NULL, GST_FLOW_ERROR); - g_return_val_if_fail ((it = gst_buffer_list_iterate (list)) != NULL, - GST_FLOW_ERROR); + + it = gst_buffer_list_iterate (list); + g_return_val_if_fail (it != NULL, GST_FLOW_ERROR); while (gst_buffer_list_iterator_next_group (it)) { msg.msg_iovlen = 0; |