summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Zeuthen <davidz@redhat.com>2009-12-09 17:14:36 -0500
committerLennart Poettering <lennart@poettering.net>2009-12-18 12:30:56 +0100
commit51502143eeb0a5553ab5977d07bf707dac47200c (patch)
treee4bf299dd224b9f1d3a7a56bf00569a34abc9020
parent54f846c2115e7addf5468a9c10ecf9ba844b946e (diff)
fix return of uninitialized variable
atasmart.c: In function ‘init_smart’: atasmart.c:2556: warning: ‘ret’ may be used uninitialized in this function We apparently don't initialize the ret variable in init_smart() - unfortunately o this warning is never reported with using -O0 (thanks gcc - see http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings though) o we never run into this bug with just skdump(1) The bug does show up in the udisks (aka DeviceKit-disks) use of libatasmart and this patch fixes it. http://bugs.freedesktop.org/show_bug.cgi?id=25543
-rw-r--r--atasmart.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/atasmart.c b/atasmart.c
index 3ff0334..d39e704 100644
--- a/atasmart.c
+++ b/atasmart.c
@@ -2579,6 +2579,7 @@ static int init_smart(SkDisk *d) {
}
disk_smart_read_thresholds(d);
+ ret = 0;
fail:
return ret;