diff options
author | Arun Raghavan <arun.raghavan@collabora.co.uk> | 2011-04-22 17:44:50 +0530 |
---|---|---|
committer | Colin Guthrie <colin@mageia.org> | 2011-04-23 18:23:38 +0100 |
commit | 8460466f8645c3b5596652c566f3624260e4d437 (patch) | |
tree | f23a7c3d06203f73b570f5c64195f1663cc6d101 | |
parent | 87570523f84817b19486ab9302314091424bbad8 (diff) |
echo-cancel: Play nice with module-filter-*
With automaticl filter loading by module-filter-apply, setting the
virtual sink/source to have the "phone" intended role will break routing
when you first connect a phone stream to an ALSA device and then turn on
your Bluetooth headset. This happens because module-intended-roles
doesn't move a stream if it is already on a device that provides the
required role.
This patch introduces a "manual_load" parameter that is meant to be used
when not using module-filter-apply for loading the AEC module. If this
parameter is set, the virtual devices are given the "phone" role, else
we count on module-filter-heuristics to do the right thing.
-rw-r--r-- | src/modules/echo-cancel/module-echo-cancel.c | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/src/modules/echo-cancel/module-echo-cancel.c b/src/modules/echo-cancel/module-echo-cancel.c index b8f269f7..746028bb 100644 --- a/src/modules/echo-cancel/module-echo-cancel.c +++ b/src/modules/echo-cancel/module-echo-cancel.c @@ -78,6 +78,7 @@ PA_MODULE_USAGE( "aec_method=<implementation to use> " "aec_args=<parameters for the AEC engine> " "save_aec=<save AEC data in /tmp> " + "manual_load=<set if this module is being loaded manually> " )); /* NOTE: Make sure the enum and ec_table are maintained in the correct order */ @@ -106,6 +107,7 @@ static const pa_echo_canceller ec_table[] = { #define DEFAULT_ADJUST_TIME_USEC (1*PA_USEC_PER_SEC) #define DEFAULT_SAVE_AEC 0 +#define DEFAULT_MANUAL_LOAD FALSE #define MEMBLOCKQ_MAXLENGTH (16*1024*1024) @@ -156,6 +158,7 @@ struct userdata { pa_core *core; pa_module *module; + pa_bool_t manual_load; uint32_t save_aec; pa_echo_canceller *ec; @@ -210,6 +213,7 @@ static const char* const valid_modargs[] = { "aec_method", "aec_args", "save_aec", + "manual_load", NULL }; @@ -1394,6 +1398,12 @@ int pa__init(pa_module*m) { goto fail; } + u->manual_load = DEFAULT_MANUAL_LOAD; + if (pa_modargs_get_value_boolean(ma, "manual_load", &u->manual_load) < 0) { + pa_log("Failed to parse manual_load value"); + goto fail; + } + u->asyncmsgq = pa_asyncmsgq_new(0); u->need_realign = TRUE; if (u->ec->init) { @@ -1413,7 +1423,8 @@ int pa__init(pa_module*m) { pa_source_new_data_set_channel_map(&source_data, &source_map); pa_proplist_sets(source_data.proplist, PA_PROP_DEVICE_MASTER_DEVICE, source_master->name); pa_proplist_sets(source_data.proplist, PA_PROP_DEVICE_CLASS, "filter"); - pa_proplist_sets(source_data.proplist, PA_PROP_DEVICE_INTENDED_ROLES, "phone"); + if (u->manual_load) + pa_proplist_sets(source_data.proplist, PA_PROP_DEVICE_INTENDED_ROLES, "phone"); pa_proplist_sets(source_data.proplist, "device.echo-cancel.name", source_data.name); if (pa_modargs_get_proplist(ma, "source_properties", source_data.proplist, PA_UPDATE_REPLACE) < 0) { @@ -1460,7 +1471,8 @@ int pa__init(pa_module*m) { pa_sink_new_data_set_channel_map(&sink_data, &sink_map); pa_proplist_sets(sink_data.proplist, PA_PROP_DEVICE_MASTER_DEVICE, sink_master->name); pa_proplist_sets(sink_data.proplist, PA_PROP_DEVICE_CLASS, "filter"); - pa_proplist_sets(sink_data.proplist, PA_PROP_DEVICE_INTENDED_ROLES, "phone"); + if (u->manual_load) + pa_proplist_sets(sink_data.proplist, PA_PROP_DEVICE_INTENDED_ROLES, "phone"); pa_proplist_sets(sink_data.proplist, "device.echo-cancel.name", sink_data.name); if (pa_modargs_get_proplist(ma, "sink_properties", sink_data.proplist, PA_UPDATE_REPLACE) < 0) { |