summaryrefslogtreecommitdiffstats
path: root/src/modules/dbus/iface-core.c
diff options
context:
space:
mode:
authorArun Raghavan <arun.raghavan@collabora.co.uk>2010-10-09 22:30:20 +0530
committerArun Raghavan <arun.raghavan@collabora.co.uk>2010-10-15 01:10:00 +0530
commit1d2ef7923d28a74e08a4309b6fa3d36481d2df3b (patch)
tree50a611811a1408f682ff21500f3f679e429c327a /src/modules/dbus/iface-core.c
parent4d84a00b495c44a9e348534bf754ace823c9abe8 (diff)
volume: Use a macro to check if a volume is valid
This adds a PA_VOLUME_IS_VALID() macro for checking if a given pa_volume_t is valid. This makes changes to the volume ranges simpler (just change PA_VOLUME_MAX, for example, without needing to modify any other code).
Diffstat (limited to 'src/modules/dbus/iface-core.c')
-rw-r--r--src/modules/dbus/iface-core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/modules/dbus/iface-core.c b/src/modules/dbus/iface-core.c
index e7c00a7b..268a87ed 100644
--- a/src/modules/dbus/iface-core.c
+++ b/src/modules/dbus/iface-core.c
@@ -1310,7 +1310,7 @@ static void handle_upload_sample(DBusConnection *conn, DBusMessage *msg, void *u
}
for (i = 0; i < n_volume_entries; ++i) {
- if (default_volume[i] > PA_VOLUME_MAX) {
+ if (!PA_VOLUME_IS_VALID(default_volume[i])) {
pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "Invalid volume: %u.", default_volume[i]);
goto finish;
}